xiaoxiang781216 commented on code in PR #6286: URL: https://github.com/apache/incubator-nuttx/pull/6286#discussion_r875147782
########## include/nuttx/arch.h: ########## @@ -1939,28 +1928,6 @@ int16_t up_fetchsub16(FAR volatile int16_t *addr, int16_t value); int8_t up_fetchsub8(FAR volatile int8_t *addr, int8_t value); #endif -/**************************************************************************** - * Name: up_cpu_index - * - * Description: - * Return an index in the range of 0 through (CONFIG_SMP_NCPUS-1) that - * corresponds to the currently executing CPU. - * - * Input Parameters: - * None - * - * Returned Value: - * An integer index in the range of 0 through (CONFIG_SMP_NCPUS-1) that - * corresponds to the currently executing CPU. - * - ****************************************************************************/ - -#ifdef CONFIG_SMP Review Comment: let's keep the prototype here, you can implement up_cpu_index as inline or not inline function freely with the prototype ########## include/nuttx/arch.h: ########## @@ -1437,17 +1437,6 @@ int up_shmdt(uintptr_t vaddr, unsigned int npages); void up_irqinitialize(void); -/**************************************************************************** - * Name: up_interrupt_context - * - * Description: - * Return true is we are currently executing in - * the interrupt handler context. - * - ****************************************************************************/ - -bool up_interrupt_context(void); Review Comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
