gustavonihei commented on code in PR #6304:
URL: https://github.com/apache/incubator-nuttx/pull/6304#discussion_r878131823
##########
arch/risc-v/src/mpfs/mpfs_ihc.c:
##########
@@ -115,22 +114,30 @@ struct mpfs_rptun_dev_s
char shmemname[RPMSG_NAME_SIZE + 1];
};
-typedef enum
-{
- IHC_CHANNEL_TO_HART0 = 0x00, /* Your hart to hart 0 */
- IHC_CHANNEL_TO_HART1 = 0x01, /* Your hart to hart 1 */
- IHC_CHANNEL_TO_HART2 = 0x02, /* Your hart to hart 2 */
- IHC_CHANNEL_TO_HART3 = 0x03, /* Your hart to hart 3 */
- IHC_CHANNEL_TO_HART4 = 0x04, /* Your hart to hart 4 */
- IHC_CHANNEL_TO_CONTEXTA = 0x05, /* Your hart to context A */
- IHC_CHANNEL_TO_CONTEXTB = 0x06, /* Your hart to context B */
-} ihc_channel_t;
-
struct mpfs_queue_table
{
void *data;
};
+enum
+{
+ MP_IRQ = 0x0,
+ ACK_IRQ = 0x1,
+};
Review Comment:
NuttX coding standard forbids the declaration of unnamed enums and structs.
##########
arch/risc-v/src/mpfs/mpfs_ihc.c:
##########
@@ -115,22 +114,30 @@ struct mpfs_rptun_dev_s
char shmemname[RPMSG_NAME_SIZE + 1];
};
-typedef enum
-{
- IHC_CHANNEL_TO_HART0 = 0x00, /* Your hart to hart 0 */
- IHC_CHANNEL_TO_HART1 = 0x01, /* Your hart to hart 1 */
- IHC_CHANNEL_TO_HART2 = 0x02, /* Your hart to hart 2 */
- IHC_CHANNEL_TO_HART3 = 0x03, /* Your hart to hart 3 */
- IHC_CHANNEL_TO_HART4 = 0x04, /* Your hart to hart 4 */
- IHC_CHANNEL_TO_CONTEXTA = 0x05, /* Your hart to context A */
- IHC_CHANNEL_TO_CONTEXTB = 0x06, /* Your hart to context B */
-} ihc_channel_t;
-
struct mpfs_queue_table
{
void *data;
};
+enum
+{
+ MP_IRQ = 0x0,
+ ACK_IRQ = 0x1,
+};
+
+struct mpfs_ihc_msg
Review Comment:
```suggestion
struct mpfs_ihc_msg_s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
