xiaoxiang781216 commented on PR #6197:
URL: https://github.com/apache/incubator-nuttx/pull/6197#issuecomment-1134893248

   > For now I suggest for 1. that in sched/task/exit.c just
   > 
   > * rename exit() -> _exit()
   > * remove old _exit()
   > * rename call to _exit() in exit() to up_exit()
   > 
   
   Sure.
   
   > This way works and prevents the system crash. _exit() does a bit more than 
it is supposed to do (flushes the streams), but it does that now anyway 
(because it calls exithook).
   > 
   
   Sure, let's remove exithook in my upcoming patch.
   
   > When the file stream handling is fixed, the extra exit hook call can be 
removed. Otherwise we still get the crash.
   
   I amn't sure why you get crash here since the code exist for a long time. 
Yes, it isn't good to flush the stdio stream inside kernel, but it should work 
not crash at least.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to