pkarashchenko commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880507077
########## libs/libc/stdlib/lib_exit.c: ########## @@ -22,13 +22,38 @@ * Included Files ****************************************************************************/ +#include <nuttx/config.h> + +#include <nuttx/atexit.h> +#include <nuttx/compiler.h> + #include <stdlib.h> #include <unistd.h> +/**************************************************************************** + * Private Data + ****************************************************************************/ + +/**************************************************************************** + * Public Data + ****************************************************************************/ + +extern FAR void *__dso_handle weak_data; +FAR void *__dso_handle = &__dso_handle; Review Comment: I'm really not sure if this line is needed ``` FAR void *__dso_handle = &__dso_handle; ``` I think it does not hurt, but still. OMO we need just to leave only ``` extern FAR void *__dso_handle[] weak_data; ``` and remove `FAR void *__dso_handle = &__dso_handle;` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
