xiaoxiang781216 commented on code in PR #1183: URL: https://github.com/apache/incubator-nuttx-apps/pull/1183#discussion_r889174006
########## system/libuv/Makefile: ########## @@ -69,12 +69,12 @@ CSRCS += posix-hrtime.c CSRCS += posix-poll.c CSRCS += uv-data-getter-setters.c CSRCS += version.c -ifneq ($(CONFIG_LIBUV_UTILS_TEST),) +ifeq ($(CONFIG_LIBUV_UTILS_TEST),) Review Comment: Yes, both idna.c and strscpy.c will be included directly when test is enabled. Please reference here: https://github.com/libuv/libuv/blob/master/test/test-idna.c#L23 https://github.com/libuv/libuv/blob/master/test/test-strscpy.c#L27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
