normanr opened a new pull request, #6416:
URL: https://github.com/apache/incubator-nuttx/pull/6416

   ## Summary
   As described at 
https://github.com/apache/incubator-nuttx/pull/5496#issuecomment-1094459216, 
the cleanup broke `CONFIG_ALLSYMS` for arm, risc-v and xtensa by including the 
linker script more than once. This fixes the issue by only passing the required 
params.
   
   I think a more "correct" way to fix this would be to list the board library 
and linker script as .EXTRA_PREREQS so that they're not included in `$^` (ref: 
https://www.gnu.org/software/make/manual/html_node/Special-Variables.html#Special-Variables),
 but that seems like a riskier change, and this just makes the command match 
the one 9 lines below in the non-`CONFIG_ALLSYMS` mode, and could potentially 
be picked into 10.3, so I'd like to keep it as simple as possible.
   
   ## Impact
   
   ## Testing
   Local testing that .config with `ALLSYMS` builds for `risc-v` `bl602`, no 
testing for other boards.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to