XinStellaris commented on code in PR #6154: URL: https://github.com/apache/incubator-nuttx/pull/6154#discussion_r895374200
########## net/tcp/tcp_conn.c: ########## @@ -49,6 +49,7 @@ #include <assert.h> #include <errno.h> #include <debug.h> +#include <sys/random.h> Review Comment: I had tested arc4random_buf, it generated the exact same sequence when system is booted. This was the reason I didn't call arc4random_buf. This is unsafe, and will cause tcp connection to fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
