pkarashchenko commented on code in PR #1195: URL: https://github.com/apache/incubator-nuttx-apps/pull/1195#discussion_r895482687
########## nshlib/nsh_envcmds.c: ########## @@ -552,7 +552,7 @@ int cmd_unset(FAR struct nsh_vtbl_s *vtbl, int argc, char **argv) /* Unset environment variable */ status = unsetenv(argv[1]); - if (status < 0) + if (status < 0 && errno != ENOENT) Review Comment: Do we need to try `unsetenv` again in case of `ENOENT`? Because now if `unsetenv` returns with `ENOENT` the `cmd_unset` returns `OK` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
