[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1199: Remove the non standard c++ header file inclusion

[GitBox]

xiaoxiang781216 commented on code in PR #1199:
URL: 
https://github.com/apache/incubator-nuttx-apps/pull/1199#discussion_r898153322


##########
graphics/nxwm/src/ckeyboard.cxx:
##########
@@ -167,7 +167,7 @@ int CKeyboard::open(void)
     {
       // Try to open the keyboard device
 
-      fd = std::open(CONFIG_NXWM_KEYBOARD_DEVPATH, O_RDONLY);
+      fd = open(CONFIG_NXWM_KEYBOARD_DEVPATH, O_RDONLY);

Review Comment:
   Since other global functions don't add ::, I prefer to keep the current 
change.



##########
graphics/nxwm/src/cnxterm.cxx:
##########
@@ -489,16 +489,16 @@ int CNxTerm::nxterm(int argc, char *argv[])
   std::fflush(stderr);
 
 #ifdef CONFIG_NXTERM_NXKBDIN
-  std::dup2(fd, 0);
+  dup2(fd, 0);
 #endif
-  std::dup2(fd, 1);
-  std::dup2(fd, 2);
+  dup2(fd, 1);
+  dup2(fd, 2);
 
   // And we can close our original driver file descriptor
 
   if (fd > 2)
     {
-      std::close(fd);
+      close(fd);

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org