acassis commented on code in PR #6418:
URL: https://github.com/apache/incubator-nuttx/pull/6418#discussion_r898172858


##########
boards/xtensa/esp32/common/Kconfig:
##########
@@ -60,6 +60,35 @@ choice ESP32_SPIFLASH_FS
 
 endchoice
 
+if LCD_SSD1680
+config SSD1680_GPIO_PIN_RST
+       int "Pin that handles the reset line (output)"
+       default "12" if ARCH_BOARD_TTGO_T5V2_ESP32
+
+config SSD1680_GPIO_PIN_BUSY
+       int "Pin that handles the busy line (input)"
+       default "4" if ARCH_BOARD_TTGO_T5V2_ESP32
+
+config SSD1680_GPIO_PIN_PWR
+       int "Pin that handles the pwr on/off line (output)"
+       default "-1" if ARCH_BOARD_TTGO_T5V2_ESP32
+
+config SSD1680_GPIO_PIN_CS
+       int "Pin that select the chip on SPI bus"
+       default "5" if ARCH_BOARD_TTGO_T5V2_ESP32
+
+config SSD1680_GPIO_PIN_DTA_CMD
+       int "Pin that switch between command and data on 4-wire SPI bus"
+       default "19" if ARCH_BOARD_TTGO_T5V2_ESP32
+
+config SSD1680_SPI_BUS
+       int "Spi bus no"

Review Comment:
   I think you missed my comment from old PR



##########
boards/xtensa/esp32/common/Kconfig:
##########
@@ -60,6 +60,35 @@ choice ESP32_SPIFLASH_FS
 
 endchoice
 
+if LCD_SSD1680
+config SSD1680_GPIO_PIN_RST
+       int "Pin that handles the reset line (output)"
+       default "12" if ARCH_BOARD_TTGO_T5V2_ESP32
+
+config SSD1680_GPIO_PIN_BUSY
+       int "Pin that handles the busy line (input)"
+       default "4" if ARCH_BOARD_TTGO_T5V2_ESP32
+
+config SSD1680_GPIO_PIN_PWR
+       int "Pin that handles the pwr on/off line (output)"
+       default "-1" if ARCH_BOARD_TTGO_T5V2_ESP32
+
+config SSD1680_GPIO_PIN_CS
+       int "Pin that select the chip on SPI bus"
+       default "5" if ARCH_BOARD_TTGO_T5V2_ESP32
+
+config SSD1680_GPIO_PIN_DTA_CMD
+       int "Pin that switch between command and data on 4-wire SPI bus"
+       default "19" if ARCH_BOARD_TTGO_T5V2_ESP32
+
+config SSD1680_SPI_BUS
+       int "Spi bus no"

Review Comment:
   ```suggestion
        int "SPI Bus Number"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to