anchao commented on code in PR #6488:
URL: https://github.com/apache/incubator-nuttx/pull/6488#discussion_r901609088
##########
drivers/wireless/ieee80211/bcm43xxx/bcmf_netdev.c:
##########
@@ -778,6 +859,9 @@ static int bcmf_txavail(FAR struct net_driver_s *dev)
{
FAR struct bcmf_dev_s *priv = (FAR struct bcmf_dev_s *)dev->d_private;
+#ifdef CONFIG_IEEE80211_BROADCOM_LOWPOWER
+ bcmf_lowpower_poll(priv);
Review Comment:
tx work thread will try again after receive data, it is more appropriate to
poll low power in txavailable
https://github.com/apache/incubator-nuttx/blob/master/drivers/wireless/ieee80211/bcm43xxx/bcmf_netdev.c#L226-L232
##########
drivers/wireless/ieee80211/bcm43xxx/bcmf_netdev.c:
##########
@@ -742,6 +750,11 @@ static int bcmf_ifdown(FAR struct net_driver_s *dev)
if (priv->bc_bifup)
{
+ if (!work_available(&priv->lp_work))
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
