acassis commented on code in PR #6494:
URL: https://github.com/apache/incubator-nuttx/pull/6494#discussion_r902931010
##########
drivers/wireless/ieee80211/bcm43xxx/bcmf_driver.c:
##########
@@ -1744,3 +1744,39 @@ int bcmf_wl_get_ssid(FAR struct bcmf_dev_s *priv, struct
iwreq *iwr)
return ret;
}
+
+int bcmf_wl_set_country_code(FAR struct bcmf_dev_s *priv,
+ int interface, FAR void *code)
+{
+ uint8_t country[4] =
+ {
+ };
+
+ uint32_t out_len;
+
+ memcpy(country, code, 2);
+
+ /* Why out_len = 4 ? Padding bytes to ensure array is
+ * terminating with null byte
+ */
+
+ out_len = sizeof(country);
+
+ return bcmf_cdc_iovar_request(priv, interface, true,
Review Comment:
Question: is the return of bcmf_cdc_iovar_request() compatible with POSIX
error number? Otherwise I think it should be important to have some debug
error/warning here to indicate the right failure, i.e.: unknown country code,
etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
