acassis commented on code in PR #6510: URL: https://github.com/apache/incubator-nuttx/pull/6510#discussion_r906413463
########## drivers/lcd/ssd1680.c: ########## @@ -577,39 +580,83 @@ static int ssd1680_configuredisplay(struct ssd1680_dev_s *priv) */ lcdinfo("Set the driver output controll (0x%02x): %d 0x%02x\n", - SSD1680_DRIVER_CONTROL, SSD1680_DEV_NATIVE_YRES - 1, + SSD1680_DRIVER_CONTROL, + SSD1680_DEV_NATIVE_YRES - 1, SSD1680_DEV_GATE_LAYOUT); ssd1680_snd_cmd_with_data3(priv, SSD1680_DRIVER_CONTROL, (uint8_t)((SSD1680_DEV_NATIVE_YRES - 1) & 0xff), (SSD1680_DEV_NATIVE_YRES - 1) >> 8, SSD1680_DEV_GATE_LAYOUT); +#if defined(CONFIG_LCD_SSD1680_2_13_V2) + /* Step 1a: Set analog block controll Review Comment: ```suggestion /* Step 1a: Set analog block control ########## drivers/lcd/ssd1680.c: ########## @@ -577,39 +580,83 @@ static int ssd1680_configuredisplay(struct ssd1680_dev_s *priv) */ lcdinfo("Set the driver output controll (0x%02x): %d 0x%02x\n", - SSD1680_DRIVER_CONTROL, SSD1680_DEV_NATIVE_YRES - 1, + SSD1680_DRIVER_CONTROL, + SSD1680_DEV_NATIVE_YRES - 1, SSD1680_DEV_GATE_LAYOUT); ssd1680_snd_cmd_with_data3(priv, SSD1680_DRIVER_CONTROL, (uint8_t)((SSD1680_DEV_NATIVE_YRES - 1) & 0xff), (SSD1680_DEV_NATIVE_YRES - 1) >> 8, SSD1680_DEV_GATE_LAYOUT); +#if defined(CONFIG_LCD_SSD1680_2_13_V2) + /* Step 1a: Set analog block controll + * After reset thise register should have proper value + */ + + lcdinfo("Set analog block controll (0x74): 0x54\n"); Review Comment: ```suggestion lcdinfo("Set analog block control (0x74): 0x54\n"); ########## drivers/lcd/ssd1680.c: ########## @@ -577,39 +580,83 @@ static int ssd1680_configuredisplay(struct ssd1680_dev_s *priv) */ lcdinfo("Set the driver output controll (0x%02x): %d 0x%02x\n", - SSD1680_DRIVER_CONTROL, SSD1680_DEV_NATIVE_YRES - 1, + SSD1680_DRIVER_CONTROL, + SSD1680_DEV_NATIVE_YRES - 1, SSD1680_DEV_GATE_LAYOUT); ssd1680_snd_cmd_with_data3(priv, SSD1680_DRIVER_CONTROL, (uint8_t)((SSD1680_DEV_NATIVE_YRES - 1) & 0xff), (SSD1680_DEV_NATIVE_YRES - 1) >> 8, SSD1680_DEV_GATE_LAYOUT); +#if defined(CONFIG_LCD_SSD1680_2_13_V2) + /* Step 1a: Set analog block controll + * After reset thise register should have proper value Review Comment: ```suggestion * After reset this register should have proper value ########## drivers/lcd/ssd1680.c: ########## @@ -577,39 +580,83 @@ static int ssd1680_configuredisplay(struct ssd1680_dev_s *priv) */ lcdinfo("Set the driver output controll (0x%02x): %d 0x%02x\n", - SSD1680_DRIVER_CONTROL, SSD1680_DEV_NATIVE_YRES - 1, + SSD1680_DRIVER_CONTROL, + SSD1680_DEV_NATIVE_YRES - 1, SSD1680_DEV_GATE_LAYOUT); ssd1680_snd_cmd_with_data3(priv, SSD1680_DRIVER_CONTROL, (uint8_t)((SSD1680_DEV_NATIVE_YRES - 1) & 0xff), (SSD1680_DEV_NATIVE_YRES - 1) >> 8, SSD1680_DEV_GATE_LAYOUT); +#if defined(CONFIG_LCD_SSD1680_2_13_V2) + /* Step 1a: Set analog block controll + * After reset thise register should have proper value + */ + + lcdinfo("Set analog block controll (0x74): 0x54\n"); + ssd1680_snd_cmd_with_data1(priv, SSD1680_SET_ANALOG_BLOCK_CTRL, 0x54); + + /* Step 1b: Set digital block controll + * After reset thise register should have proper value + */ + + lcdinfo("Set digital block controll (0x7e): 0x3b\n"); Review Comment: ```suggestion lcdinfo("Set digital block control (0x7e): 0x3b\n"); ########## drivers/lcd/ssd1680.c: ########## @@ -577,39 +580,83 @@ static int ssd1680_configuredisplay(struct ssd1680_dev_s *priv) */ lcdinfo("Set the driver output controll (0x%02x): %d 0x%02x\n", - SSD1680_DRIVER_CONTROL, SSD1680_DEV_NATIVE_YRES - 1, + SSD1680_DRIVER_CONTROL, + SSD1680_DEV_NATIVE_YRES - 1, SSD1680_DEV_GATE_LAYOUT); ssd1680_snd_cmd_with_data3(priv, SSD1680_DRIVER_CONTROL, (uint8_t)((SSD1680_DEV_NATIVE_YRES - 1) & 0xff), (SSD1680_DEV_NATIVE_YRES - 1) >> 8, SSD1680_DEV_GATE_LAYOUT); +#if defined(CONFIG_LCD_SSD1680_2_13_V2) + /* Step 1a: Set analog block controll + * After reset thise register should have proper value + */ + + lcdinfo("Set analog block controll (0x74): 0x54\n"); + ssd1680_snd_cmd_with_data1(priv, SSD1680_SET_ANALOG_BLOCK_CTRL, 0x54); + + /* Step 1b: Set digital block controll Review Comment: ```suggestion /* Step 1b: Set digital block control ########## drivers/lcd/ssd1680.c: ########## @@ -671,69 +731,28 @@ static int ssd1680_configuredisplay(struct ssd1680_dev_s *priv) * priv - Reference to private driver structure * * Assumptions: - * Caller has selected the OLED section. + * E-ink is slow, so we don't need to optimize cod in order to send all Review Comment: ```suggestion * E-ink is slow, so we don't need to optimize code in order to send all -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org