xiaoxiang781216 commented on code in PR #6518:
URL: https://github.com/apache/incubator-nuttx/pull/6518#discussion_r906642299
##########
drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.c:
##########
@@ -132,23 +131,96 @@ static struct bcmf_sdio_frame
int bcmf_oob_irq(FAR void *arg)
{
FAR struct bcmf_sdio_dev_s *sbus = (FAR struct bcmf_sdio_dev_s *)arg;
+ int semcount;
if (sbus->ready)
{
/* Signal bmcf thread */
sbus->irq_pending = true;
- nxsem_post(&sbus->thread_signal);
+
+ nxsem_get_value(&sbus->thread_signal, &semcount);
+ if (semcount < 0)
Review Comment:
<= ? otherwise you may lose the event
##########
drivers/wireless/ieee80211/bcm43xxx/bcmf_sdpcm.c:
##########
@@ -470,7 +471,11 @@ int bcmf_sdpcm_queue_frame(FAR struct bcmf_dev_s *priv,
/* Notify bcmf thread tx frame is ready */
- nxsem_post(&sbus->thread_signal);
+ nxsem_get_value(&sbus->thread_signal, &semcount);
+ if (semcount < 0)
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
