gustavonihei commented on code in PR #6511:
URL: https://github.com/apache/incubator-nuttx/pull/6511#discussion_r907324042


##########
boards/xtensa/esp32/common/Kconfig:
##########
@@ -77,10 +77,6 @@ config SSD1680_GPIO_PIN_CS
        int "Pin that select the chip on SPI bus"
        default "5" if ARCH_BOARD_TTGO_T5V2_ESP32
 
-config SSD1680_GPIO_PIN_DTA_CMD

Review Comment:
   Please, extend this change to the other pins as well.
   They are specific to `ARCH_BOARD_TTGO_T5V2_ESP32`, so they should not be 
placed under the common Kconfig.
   
   `SSD1680_GPIO_PIN_CS` should instead use `ESP32_SPI3_CSPIN` option for the 
CS pin.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to