xiaoxiang781216 commented on code in PR #6532: URL: https://github.com/apache/incubator-nuttx/pull/6532#discussion_r907680342
########## boards/renesas/m16c/skp16c26/scripts/Make.defs: ########## @@ -50,5 +50,4 @@ CPPFLAGS = $(ARCHINCLUDES) $(ARCHDEFINES) $(EXTRAFLAGS) AFLAGS = $(CFLAGS) -D__ASSEMBLY__ ifeq ($(CONFIG_DEBUG_SYMBOLS),y) Review Comment: remove ifeq/endif ########## arch/xtensa/src/lx7/Toolchain.defs: ########## @@ -101,8 +101,7 @@ ifeq ($(CONFIG_DEBUG_LINK_MAP),y) endif ifeq ($(CONFIG_DEBUG_SYMBOLS),y) - LDFLAGS += -g - ARCHOPTIMIZATION += -g + ARCHOPTIMIZATION += -g Review Comment: why change the indent? ########## arch/xtensa/src/lx6/Toolchain.defs: ########## @@ -101,8 +101,7 @@ ifeq ($(CONFIG_DEBUG_LINK_MAP),y) endif ifeq ($(CONFIG_DEBUG_SYMBOLS),y) - LDFLAGS += -g - ARCHOPTIMIZATION += -g + ARCHOPTIMIZATION += -g Review Comment: please restore the indent in all place -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
