gustavonihei commented on code in PR #6511: URL: https://github.com/apache/incubator-nuttx/pull/6511#discussion_r908423654
########## boards/xtensa/esp32/common/src/esp32_ssd1680.c: ########## @@ -105,9 +105,8 @@ int board_lcd_initialize(void) /* Initialize additional I/O for e-ink display */ -#if defined(CONFIG_SSD1680_GPIO_PIN_DTA_CMD) && \ - (CONFIG_SSD1680_GPIO_PIN_DTA_CMD >= 0) - esp32_configgpio(CONFIG_SSD1680_GPIO_PIN_DTA_CMD, OUTPUT); +#if defined(DISPLAY_DC) && (DISPLAY_DC >= 0) Review Comment: I had overlooked the latest changes and I just noticed that now the build will indeed fail in case the necessary defines are not present. If I understood correctly, the only define that must be present is `DISPLAY_DC`, the others are optional for the driver operation. I am okay with this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
