onegray commented on code in PR #6422: URL: https://github.com/apache/incubator-nuttx/pull/6422#discussion_r909503411
########## arch/arm/src/stm32wb/stm32wb_spi.c: ########## @@ -0,0 +1,1819 @@ +/**************************************************************************** Review Comment: The meaning differences is caused by the fact that this SPI implementation is derived from stm32l4, while the stm32wl5 is based on generic stm32. Mostly they are the same, but from the git log I see that the stm32l4 SPI implementation is ahead by this commit: [|arch/arm/src/stm32l4: Add PM hooks to I2C, SPI and 1-wire](https://github.com/apache/incubator-nuttx/commit/a36c7a779ad977fc58704af0b5165a18bd5d5982) And the generic stm32 is ahead by those three: [stm32: Use the consistent type for stm32_dmacapable](https://github.com/apache/incubator-nuttx/commit/01abc41caf98a384c969ca7a7af2e7c35213d7a1) [stm32:spi Add buffers for DMA](https://github.com/apache/incubator-nuttx/commit/6189b2c8bd36a6ee2a9b1e5fd58b994ecf585dc2) [arm/stm32 add STM32_SPI_DMATHRESHOLD](https://github.com/apache/incubator-nuttx/commit/afb2248b7a47ec4ab72f10fe21100d538af67934) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
