xiaoxiang781216 commented on code in PR #6576:
URL: https://github.com/apache/incubator-nuttx/pull/6576#discussion_r915441630
##########
drivers/video/vnc/vnc_fbdev.c:
##########
@@ -610,6 +612,22 @@ int up_fbinitialize(int display)
return ret;
}
+ /* Save the input callout function information in the session structure. */
+
+ session = g_vnc_sessions[display];
+#ifdef CONFIG_VNCSERVER_TOUCH
+ ret = vnc_touch_register(CONFIG_VNCSERVER_TOUCH_DEVNAME, &session->touch);
Review Comment:
we need generate the touch device dynamically to support the multiple
instance
##########
drivers/video/vnc/vnc_server.h:
##########
@@ -222,6 +223,10 @@ struct vnc_session_s
vnc_mouseout_t mouseout; /* Callout when keyboard input is received */
FAR void *arg; /* Argument that accompanies the callouts */
+#ifdef CONFIG_VNCSERVER_TOUCH
+ FAR struct touch_lowerhalf_s *touch; /* Touch driver instance */
Review Comment:
why not embed touch directly in vnc_session_s
##########
drivers/video/vnc/vnc_fbdev.c:
##########
@@ -610,6 +612,22 @@ int up_fbinitialize(int display)
return ret;
}
+ /* Save the input callout function information in the session structure. */
+
+ session = g_vnc_sessions[display];
+#ifdef CONFIG_VNCSERVER_TOUCH
+ ret = vnc_touch_register(CONFIG_VNCSERVER_TOUCH_DEVNAME, &session->touch);
+
+ if (ret < 0)
Review Comment:
sorry, look like the background thread is start at line vnc_start_server, so
we need move before vnc_start_server
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
