xiaoxiang781216 commented on code in PR #6618:
URL: https://github.com/apache/incubator-nuttx/pull/6618#discussion_r922674819
##########
arch/arm/src/common/arm_semi_syslog.c:
##########
@@ -54,15 +52,25 @@ int up_putc(int ch)
}
/****************************************************************************
- * Name: up_puts
+ * Name: up_nputs
*
* Description:
* Output a string on the console
*
****************************************************************************/
-void up_puts(const char *str)
+void up_nputs(const char *str, size_t len)
{
- smh_call(SEMI_SYSLOG_WRITE0, (char *)str);
+ if (len == ~((size_t)0))
+ {
+ smh_call(SEMI_SYSLOG_WRITE0, (char *)str);
Review Comment:
SEMI_SYSLOG_WRITE0 is defined by ARM, we can't change it as we want to:
https://github.com/ARM-software/abi-aa/blob/main/semihosting/semihosting.rst#sys-write0-0x04
since the PC tool will stop working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
