[GitHub] [incubator-nuttx] ALTracer commented on a diff in pull request #6632: Add printflike and scanflike to all printf/scanf like functions

[GitBox]

ALTracer commented on code in PR #6632:
URL: https://github.com/apache/incubator-nuttx/pull/6632#discussion_r922889604


##########
drivers/usbdev/usbdev_trprintf.c:
##########
@@ -97,10 +97,10 @@ void usbtrace_trprintf(trprintf_t trprintf, uint16_t event, 
uint16_t value)
     case TRACE_DEVINIT:
 #ifdef CONFIG_USBDEV_TRACE_STRINGS
       trprintf("%-18s   : %-40s %04x\n", "DCD initialize",
-               TRACE_DATA(event), "Initialized", value);
+               "Initialized", value);
 #else
       trprintf("%-18s   : %04x\n", "DCD initialize",
-               TRACE_DATA(event), value);

Review Comment:
   What happened here? Does TRACE_DEVINIT event not need a TRACE_DATA code be 
output via some %3d here, like in the other events? Or was this someone's 
copy-paste error that the PR unearthed? git annotate shows a 9 year old commit 
touching there lines.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org