mlyszczek commented on code in PR #6537: URL: https://github.com/apache/incubator-nuttx/pull/6537#discussion_r923164475
########## drivers/ipcc/ipcc_unlink.c: ########## @@ -0,0 +1,94 @@ +/**************************************************************************** + * drivers/ipcc/ipcc_unlink.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <nuttx/ipcc.h> +#include <nuttx/kmalloc.h> +#include <nuttx/semaphore.h> + +#include <assert.h> +#include <errno.h> +#include <stdbool.h> +#include <stdio.h> +#include <sys/types.h> + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: ipcc_unlink + * + * Description: + * Action to take upon file unlinking. Function will free resources if + * noone is using the driver when unlinking occured. If driver is still + * in use, it will be marked as unlinked and resource freeing will take + * place in ipcc_close() function instead, once last reference is closed. + * + * Input Parameters: + * inode - driver inode that is being unlinked + * + * Returned Value: + * OK on successfull close, or negated errno on failure. + * + * Assumptions/Limitations: + * + ****************************************************************************/ + +int ipcc_unlink(FAR struct inode *inode) Review Comment: Not sure about that. What about case, when you want to send some stuff over channel during initialization, and then free resources for other things for the rest of the project live? I understand it's a corner case and freeing is not good thing to do in embedded. But since the code is here, why not let it stay so the driver can be more complete? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
