xiaoxiang781216 commented on code in PR #6724:
URL: https://github.com/apache/incubator-nuttx/pull/6724#discussion_r931915457
##########
fs/procfs/fs_procfsproc.c:
##########
@@ -284,6 +292,11 @@ static const struct proc_node_s g_heap =
{
"heap", "heap", (uint8_t)PROC_HEAP, DTYPE_FILE /*
Task heap info */
};
+
+static const struct proc_node_s g_heapcheck =
Review Comment:
should guard by #ifdef CONFIG_DEBUG_MM
##########
fs/procfs/fs_procfsproc.c:
##########
@@ -328,6 +341,7 @@ static FAR const struct proc_node_s * const g_nodeinfo[] =
#endif
#if CONFIG_MM_BACKTRACE >= 0
&g_heap, /* Task heap info */
+ &g_heapcheck, /* Task heap check flag */
Review Comment:
should guard by #ifdef CONFIG_DEBUG_MM
##########
fs/procfs/fs_procfsproc.c:
##########
@@ -950,6 +965,53 @@ static ssize_t proc_heap(FAR struct proc_file_s *procfile,
&offset);
return totalsize;
}
+
+static ssize_t proc_heapcheck(FAR struct proc_file_s *procfile,
Review Comment:
ditto
##########
fs/procfs/fs_procfsproc.c:
##########
@@ -354,6 +368,7 @@ static const struct proc_node_s * const g_level0info[] =
#endif
#if CONFIG_MM_BACKTRACE >= 0
&g_heap, /* Task heap info */
+ &g_heapcheck, /* Task heap check flag */
Review Comment:
ditto
##########
fs/procfs/fs_procfsproc.c:
##########
@@ -182,6 +183,12 @@ static ssize_t proc_critmon(FAR struct proc_file_s
*procfile,
static ssize_t proc_heap(FAR struct proc_file_s *procfile,
FAR struct tcb_s *tcb, FAR char *buffer,
size_t buflen, off_t offset);
+static ssize_t proc_heapcheck(FAR struct proc_file_s *procfile,
Review Comment:
should guard by #ifdef CONFIG_DEBUG_MM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
