acassis commented on code in PR #1238: URL: https://github.com/apache/incubator-nuttx-apps/pull/1238#discussion_r933504741
########## games/shift/shift_input_console.h: ########## @@ -0,0 +1,133 @@ +/**************************************************************************** + * apps/games/shift/shift_input_console.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <termios.h> + +#include "shift_inputs.h" + +/**************************************************************************** + * Preprocessor Definitions + ****************************************************************************/ + +/* Termios functions to have getch on Linux/NuttX */ + +static struct termios g_old; +static struct termios g_new; + +/* Initialize g_new terminal I/O settings */ + +void init_termios(int echo) +{ + tcgetattr(0, &g_old); /* grab old terminal i/o settings */ + g_new = g_old; /* use old settings as starting */ + g_new.c_lflag &= ~ICANON; /* disable buffered I/O */ + g_new.c_lflag &= ~ECHO; /* disable ECHO bit */ + g_new.c_lflag |= echo ? ECHO : 0; /* set echo mode if requested */ + tcsetattr(0, TCSANOW, &g_new); /* apply terminal I/O settings */ +} + +/* Restore g_old terminal i/o settings */ + +void reset_termios(void) +{ + tcsetattr(0, TCSANOW, &g_old); +} + +/* Read 1 character - echo defines echo mode */ + +char getch_(int echo) +{ + char ch; + + init_termios(echo); + ch = getchar(); + reset_termios(); + + return ch; +} + +/* Read 1 character without echo getch() function definition. */ + +char getch(void) +{ + return getch_(0); +} + +/**************************************************************************** + * dev_input_init + ****************************************************************************/ + +int dev_input_init(FAR struct input_state_s *dev) +{ + init_termios(0); + + return OK; +} + +/**************************************************************************** + * dev_read_input + ****************************************************************************/ + +int dev_read_input(FAR struct input_state_s *dev) +{ + char ch; + + /* Arrows keys return three bytes: 27 91 [65-68] */ + + if ((ch = getch()) == 27) + { + if ((ch = getch()) == 91) + { + ch = getch(); + if (ch == 65) + { + dev->dir = DIR_UP; + } + else if (ch == 66) + { + dev->dir = DIR_DOWN; + } + else if (ch == 67) + { + dev->dir = DIR_RIGHT; + } + else if (ch == 68) + { + dev->dir = DIR_LEFT; + } Review Comment: I think the nxstyle.c needs to be fixed to this case where we move the braces to just below the external (right most) "if (". Also need to be fixed to catch "case" with more than 2 spaces in the next line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
