hartmannathan commented on PR #7001:
URL: https://github.com/apache/incubator-nuttx/pull/7001#issuecomment-1236833563

   Specifically, these need changes in out-of-tree boards:
   
   https://github.com/apache/incubator-nuttx/pull/6276 - Remove `-nostartfiles` 
and `-nodefaultlibs` from individual board `Make.defs`.
   
   https://github.com/apache/incubator-nuttx/pull/6256 - Remove `ARCHWARNINGS = 
-Wall -Wstrict-prototypes -Wshadow -Wundef` and `ARCHWARNINGSXX = -Wall 
-Wshadow -Wundef` and then remove `ARCHWARNINGS` and `ARCHWARNINGSXX` from 
`CFLAGS` and `CXXFLAGS`.
   
   https://github.com/apache/incubator-nuttx/pull/5897 - Remove 
`-fno-exceptions -fcheck-new` from `ARCHCFLAGS` and `ARCHCXXFLAGS` and change 
`ARCHCFLAGS =` to `ARCHCFLAGS +=` and `ARCHCXXFLAGS =` to `ARCHCXXFLAGS +=`. 
C++ exceptions are now managed centrally by Kconfig options 
`CONFIG_CXX_EXCEPTION` and `CONFIG_CXX_RTTI`.
   
   https://github.com/apache/incubator-nuttx/pull/6144 - Remove from each board:
   ```
   ifeq ($(CONFIG_DEBUG_SYMBOLS),y)
     ARCHOPTIMIZATION = -g
   endif
   ```
   and
   ```
   ifeq ($(CONFIG_DEBUG_SYMBOLS),y)
     LDFLAGS += -g
   endif
   ```
   as these are now managed centrally by Kconfig option `CONFIG_DEBUG_SYMBOLS`.
   
   https://github.com/apache/incubator-nuttx/pull/6155 - Remove from each board:
   ```
   ifneq ($(CONFIG_DEBUG_NOOPT),y)
     ARCHOPTIMIZATION += $(MAXOPTIMIZATION) -fno-strict-aliasing
   endif
   ```
   as these are now managed centrally by Kconfig options 
`CONFIG_DEBUG_OPTLEVEL` and `CONFIG_DEBUG_FULLOPT`.
   
   https://github.com/apache/incubator-nuttx/pull/5496 - Replace:
   ```
   ifeq ($(CONFIG_CYGWIN_WINTOOL),y)
     ARCHSCRIPT = -T "${shell cygpath -w 
$(BOARD_DIR)$(DELIM)scripts$(DELIM)$(LDSCRIPT)}"
   else
     ARCHSCRIPT = -T$(BOARD_DIR)$(DELIM)scripts$(DELIM)$(LDSCRIPT)
   endif
   ```
   with:
   ```
    ARCHSCRIPT += $(BOARD_DIR)$(DELIM)scripts$(DELIM)$(LDSCRIPT)
   ```
   
   I think these are all of the breaking changes that require an explanation in 
the release notes. I'll make sure each PR is tagged with breaking change and 
build system.
   
   I can add the explanations to the release notes: Are we still using 
Confluence for that?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to