hartmannathan commented on PR #7103:
URL: https://github.com/apache/incubator-nuttx/pull/7103#issuecomment-1248574658

   > "For out-of-tree custom boards: a path relative to TOPDIR to the custom 
board's configuration directory (e.g. 
../mycustomboards/myboardname/config/nsh)."
   > 
   > If CONFIG_ARCH_BOARD_CUSTOM_DIR_RELPATH is not set, then an absolute path 
is used. See tools/Config.mk:
   > 
   > ```
   > 138   ifeq ($(CONFIG_ARCH_BOARD_CUSTOM_DIR_RELPATH),y)
   > 139     BOARD_DIR ?= $(TOPDIR)$(DELIM)$(CUSTOM_DIR)
   > 140   else
   > 141     BOARD_DIR ?= $(CUSTOM_DIR)
   > 142   endif
   > ```
   
   Oh I see, the script tries to use a relative path first, followed by an 
absolute path:
   
   ```
   configpath=${TOPDIR}/boards/*/*/${boarddir}/configs/${configdir}
   if [ ! -d ${configpath} ]; then
     # Try direct path used with custom configurations.
   
     configpath=${TOPDIR}/${boardconfig}
     if [ ! -d ${configpath} ]; then
       configpath=${boardconfig}
       if [ ! -d ${configpath} ]; then
         echo "Directory for ${boardconfig} does not exist." 1>&2
         echo "" 1>&2
         echo "Run tools/configure.sh -L to list available configurations." 1>&2
         echo "$USAGE" 1>&2
         exit 3
       fi
     fi
   fi
   ```
   
   I missed that the first time.
   
   So the updated text should read something like:
   
   "...a TOPDIR-relative path or an absolute path to the custom board's 
configuration directory..."
   
   I don't know whether we should document the need for 
`CONFIG_ARCH_BOARD_CUSTOM_DIR_RELPATH` in the USAGE text. That doesn't seem to 
be the right place for it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to