[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7131: poll: add poll_notify() api and call it in all drivers.

[GitBox]

xiaoxiang781216 commented on code in PR #7131:
URL: https://github.com/apache/incubator-nuttx/pull/7131#discussion_r978284154


##########
net/rpmsg/rpmsg_sockif.c:
##########
@@ -910,7 +890,7 @@ static int rpmsg_socket_poll(FAR struct socket *psock,
 
       if (eventset)

Review Comment:
   remove?



##########
net/icmpv6/icmpv6_netpoll.c:
##########
@@ -111,8 +111,7 @@ static uint16_t icmpv6_poll_eventhandler(FAR struct 
net_driver_s *dev,
 
       if (eventset)

Review Comment:
   remove



##########
fs/vfs/fs_eventfd.c:
##########
@@ -540,7 +514,7 @@ static int eventfd_do_poll(FAR struct file *filep, FAR 
struct pollfd *fds,
 
   if (eventset)

Review Comment:
   remove



##########
net/can/can_sockif.c:
##########
@@ -143,15 +143,14 @@ static uint16_t can_poll_eventhandler(FAR struct 
net_driver_s *dev,
       else if ((flags & CAN_POLL) != 0 &&
                  psock_can_cansend(info->psock) >= 0)
         {
-          eventset |= (POLLOUT & info->fds->events);
+          eventset |= POLLOUT;
         }
 
       /* Awaken the caller of poll() is requested event occurred. */
 
       if (eventset)

Review Comment:
   remove



##########
net/icmp/icmp_netpoll.c:
##########
@@ -111,8 +111,7 @@ static uint16_t icmp_poll_eventhandler(FAR struct 
net_driver_s *dev,
 
       if (eventset)

Review Comment:
   remove



##########
drivers/usrsock/usrsock_dev.c:
##########
@@ -514,7 +491,7 @@ static int usrsockdev_poll(FAR struct file *filep, FAR 
struct pollfd *fds,
 
       if (eventset)

Review Comment:
   remove



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org