xiaoxiang781216 commented on code in PR #7191:
URL: https://github.com/apache/incubator-nuttx/pull/7191#discussion_r980788241
##########
arch/xtensa/src/esp32/esp32_spiflash.c:
##########
@@ -1570,9 +1570,7 @@ static ssize_t esp32_read(struct mtd_dev_s *dev, off_t
offset,
finfo("esp32_read()=%d\n", ret);
#endif
-error_with_buffer:
-
- return (ssize_t)ret;
+ return ret;
Review Comment:
Done.
##########
drivers/bch/bchdev_driver.c:
##########
@@ -261,7 +261,7 @@ static off_t bch_seek(FAR struct file *filep, off_t offset,
int whence)
* point, subsequent reads of data in the gap shall return bytes with the
* value 0 until data is actually written into the gap."
*
- * We can conform to the first part, but not the second. But return EINVAL
+ * We can conform to the first part, but not the second. But return -EINVAL
Review Comment:
ditto
##########
drivers/eeprom/i2c_xx24xx.c:
##########
@@ -497,7 +497,7 @@ static off_t ee24xx_seek(FAR struct file *filep, off_t
offset, int whence)
* this point, subsequent reads of data in the gap shall return bytes
* with the value 0 until data is actually written into the gap."
*
- * We can conform to the first part, but not the second. But return EINVAL
+ * We can conform to the first part, but not the second. But return -EINVAL
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
