[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7207: fs/poll: using callback mechanism to implement poll notification

[GitBox]

xiaoxiang781216 commented on code in PR #7207:
URL: https://github.com/apache/incubator-nuttx/pull/7207#discussion_r981975042


##########
include/sys/poll.h:
##########
@@ -144,6 +150,8 @@ int ppoll(FAR struct pollfd *fds, nfds_t nfds,
           FAR const struct timespec *timeout_ts,
           FAR const sigset_t *sigmask);
 
+void poll_default_cb(FAR struct pollfd *fds);

Review Comment:
   change to static



##########
drivers/net/telnet.c:
##########
@@ -1281,7 +1281,8 @@ static int telnet_io_main(int argc, FAR char** argv)
               (CONFIG_TELNET_RXBUFFER_SIZE -
                priv->td_pending - priv->td_offset) > 0)
             {
-              priv->td_fds.sem     = &g_iosem;
+              priv->td_fds.cbargs  = &g_iosem;

Review Comment:
   could we let telnet call nx_poll api instead psock_poll



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org