gustavonihei commented on code in PR #6920: URL: https://github.com/apache/incubator-nuttx/pull/6920#discussion_r983524077
########## crypto/Kconfig: ########## @@ -39,6 +39,11 @@ config CRYPTO_CRYPTODEV bool "cryptodev support" default n +config CRYPTO_CRYPTODEV_HARDWARE + bool "cryptodev hardware support" + depends on CRYPTO_CRYPTODEV + default n + config CRYPTO_SW_AES Review Comment: I am referring to just the Kconfig options, so why not do it on this PR? PRs should bring self-contained changes. If I understood correctly, this PR in its current state is adding new BSD-licensed components, so the correct would be properly "hide" them behind the `ALLOW_BSD_COMPONENTS` config. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org