pkarashchenko commented on code in PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r985474716
########## arch/arm/src/cxd56xx/cxd56_udmac.c: ########## @@ -238,7 +239,7 @@ void cxd56_udmainitialize(void) /* Initialize the channel list */ - nxsem_init(&g_dmac.exclsem, 0, 1); + nxmutex_init(&g_dmac.lock); nxsem_init(&g_dmac.chansem, 0, CXD56_DMA_NCHANNELS); Review Comment: I think that is not a good way. If I understand correctly we will have a Kconfig option so users can select either enable or disable by default. Having explicit calls will break this dependency. Unless we will have Kconfig applied only for nxmutex. In such a way I agree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
