[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6965: nxmutex replace nxsem when used as a lock

[GitBox]

xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r988534543


##########
drivers/audio/cxd56.c:
##########
@@ -1312,15 +1312,15 @@ static void _process_audio_with_src(cxd56_dmahandle_t 
hdl, uint16_t err_code)
     {
       FAR struct ap_buffer_s *src_apb;
 
-      src_apb = (struct ap_buffer_s *) dq_get(&dev->down_runq);
+      src_apb = (struct ap_buffer_s *)dq_get(&dev->down_runq);

Review Comment:
   Let's keep as before since:
   
   1. All pointer doesn't add FAR
   2. It's specific to Spresense(arm core)



##########
drivers/audio/cxd56.c:
##########
@@ -1312,15 +1312,15 @@ static void _process_audio_with_src(cxd56_dmahandle_t 
hdl, uint16_t err_code)
     {
       FAR struct ap_buffer_s *src_apb;
 
-      src_apb = (struct ap_buffer_s *) dq_get(&dev->down_runq);
+      src_apb = (struct ap_buffer_s *)dq_get(&dev->down_runq);
       src_apb->nbytes = 0;
       dq_put(&dev->down_doneq, &src_apb->dq_entry);
 
       if (src_apb->flags & AUDIO_APB_SRC_FINAL)
         {
           struct ap_buffer_s *apb;

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org