[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6965: nxmutex replace nxsem when used as a lock

[GitBox]

pkarashchenko commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r988977542


##########
boards/arm/stm32/mikroe-stm32f4/src/stm32_mio283qt2.c:
##########
@@ -274,9 +274,9 @@ static void stm32_index(struct mio283qt2_lcd_s *dev, 
uint8_t index)
 static uint16_t stm32_read(struct mio283qt2_lcd_s *dev)
 {
   struct stm32f4_dev_s *priv = (struct stm32f4_dev_s *)dev;
-  uint32_t  * volatile portsetreset = (uint32_t *) STM32_GPIOE_BSRR;
-  uint32_t  * volatile portmode = (uint32_t *) STM32_GPIOE_MODER;
-  uint32_t  * volatile portinput = (uint32_t *) STM32_GPIOE_IDR;
+  volatile uint32_t *portsetreset = (uint32_t *)STM32_GPIOE_BSRR;

Review Comment:
   good finding.



##########
arch/risc-v/src/esp32c3/esp32c3_tim.c:
##########
@@ -82,7 +82,7 @@ static void esp32c3_tim_setalarm(struct esp32c3_tim_dev_s 
*dev,
 static void esp32c3_tim_setautoreload(struct esp32c3_tim_dev_s *dev,
                                       bool enable);
 static int esp32c3_tim_setisr(struct esp32c3_tim_dev_s *dev,
-                               xcpt_t handler, void * arg);
+                               xcpt_t handler, void *arg);

Review Comment:
   ```suggestion
                                 xcpt_t handler, void *arg);
   ```



##########
drivers/mtd/smart.c:
##########
@@ -120,7 +120,7 @@
 #endif
 
 #ifndef offsetof
-#define offsetof(type, member) ( (size_t) &( ( (type *) 0)->member))
+#define offsetof(type, member) ( (size_t) &( ( (type *)0)->member))

Review Comment:
   ```suggestion
   #  define offsetof(type, member) ((size_t)&(((type *)0)->member))
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org