pkarashchenko commented on code in PR #1340:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r990694889
##########
examples/ustream/ustream_client.c:
##########
@@ -90,7 +90,7 @@ int main(int argc, FAR char *argv[])
printf("client: Connecting to %s...\n", CONFIG_EXAMPLES_USTREAM_ADDR);
addrlen += sizeof(sa_family_t) + 1;
- ret = connect( sockfd, (struct sockaddr *)&myaddr, addrlen);
+ ret = connect(sockfd, (struct sockaddr *)&myaddr, addrlen);
Review Comment:
```suggestion
ret = connect(sockfd, (FAR struct sockaddr *)&myaddr, addrlen);
```
##########
netutils/libcurl4nx/curl4nx_easy_perform.c:
##########
@@ -140,15 +140,15 @@ static int curl4nx_is_header(FAR char *buf, int len,
int curl4nx_easy_perform(FAR struct curl4nx_s *handle)
{
struct sockaddr_in server;
- FILE * stream; /* IOSTREAM used to printf in the socket TODO
avoid */
+ FILE *stream; /* IOSTREAM used to printf in the socket TODO
avoid */
Review Comment:
```suggestion
FAR FILE *stream; /* IOSTREAM used to printf in the
socket TODO avoid */
```
##########
netutils/libcurl4nx/curl4nx_easy_perform.c:
##########
@@ -140,15 +140,15 @@ static int curl4nx_is_header(FAR char *buf, int len,
int curl4nx_easy_perform(FAR struct curl4nx_s *handle)
{
struct sockaddr_in server;
- FILE * stream; /* IOSTREAM used to printf in the socket TODO
avoid */
+ FILE *stream; /* IOSTREAM used to printf in the socket TODO
avoid */
int rxoff; /* Current offset within RX buffer */
char tmpbuf[16]; /* Buffer to hold small strings */
int tmplen; /* Number of bytes used in tmpbuffer */
int state; /* Current state of the parser */
int ret; /* Return value from internal calls */
- char * headerbuf;
+ char *headerbuf;
Review Comment:
```suggestion
FAR char *headerbuf;
```
##########
system/nxplayer/nxplayer.c:
##########
@@ -516,9 +516,9 @@ static inline int nxplayer_fmtfromextension(FAR struct
nxplayer_s *pplayer,
FAR const char *pfilename,
FAR int *subfmt)
{
- const char *pext;
- uint8_t x;
- uint8_t c;
+ const char *pext;
Review Comment:
```suggestion
FAR const char *pext;
```
##########
netutils/usrsock_rpmsg/usrsock_rpmsg_client.c:
##########
@@ -262,7 +262,7 @@ int main(int argc, char *argv[])
while (1)
{
struct pollfd pfd;
- void *buf;
+ void *buf;
Review Comment:
```suggestion
FAR void *buf;
```
##########
netutils/libcurl4nx/curl4nx_easy_perform.c:
##########
@@ -140,15 +140,15 @@ static int curl4nx_is_header(FAR char *buf, int len,
int curl4nx_easy_perform(FAR struct curl4nx_s *handle)
{
struct sockaddr_in server;
- FILE * stream; /* IOSTREAM used to printf in the socket TODO
avoid */
+ FILE *stream; /* IOSTREAM used to printf in the socket TODO
avoid */
int rxoff; /* Current offset within RX buffer */
char tmpbuf[16]; /* Buffer to hold small strings */
int tmplen; /* Number of bytes used in tmpbuffer */
int state; /* Current state of the parser */
int ret; /* Return value from internal calls */
- char * headerbuf;
+ char *headerbuf;
int headerlen;
- char * end;
+ char *end;
Review Comment:
```suggestion
FAR char *end;
```
##########
system/nxrecorder/nxrecorder.c:
##########
@@ -225,21 +225,21 @@ static int nxrecorder_enqueuebuffer(FAR struct
nxrecorder_s *precorder,
static void *nxrecorder_recordthread(pthread_addr_t pvarg)
{
- struct nxrecorder_s *precorder = (struct nxrecorder_s *)pvarg;
- struct audio_msg_s msg;
- struct audio_buf_desc_s buf_desc;
- ssize_t size;
- bool running = true;
- bool streaming = true;
- bool failed = false;
- struct ap_buffer_info_s buf_info;
- FAR struct ap_buffer_s **pbuffers;
- unsigned int prio;
+ struct nxrecorder_s *precorder = (struct nxrecorder_s *)pvarg;
Review Comment:
```suggestion
FAR struct nxrecorder_s *precorder = (FAR struct nxrecorder_s *)pvarg;
```
##########
system/nxplayer/nxplayer.c:
##########
@@ -74,9 +74,9 @@
#ifdef CONFIG_NXPLAYER_FMT_FROM_EXT
struct nxplayer_ext_fmt_s
{
- const char *ext;
- uint16_t format;
- CODE int (*getsubformat)(int fd);
+ const char *ext;
Review Comment:
```suggestion
FAR const char *ext;
```
##########
system/zmodem/zm_send.c:
##########
@@ -1596,7 +1596,7 @@ ZMSHANDLE zms_initialize(int remfd)
* or command if it were not already active.
*/
- nwritten = zm_remwrite(pzm->remfd, (uint8_t *) "rz\r", 3);
+ nwritten = zm_remwrite(pzm->remfd, (uint8_t *)"rz\r", 3);
Review Comment:
```suggestion
nwritten = zm_remwrite(pzm->remfd, (FAR uint8_t *)"rz\r", 3);
```
##########
system/nxplayer/nxplayer.c:
##########
@@ -752,21 +752,21 @@ static int nxplayer_enqueuebuffer(FAR struct nxplayer_s
*pplayer,
static void *nxplayer_playthread(pthread_addr_t pvarg)
Review Comment:
```suggestion
static FAR void *nxplayer_playthread(pthread_addr_t pvarg)
```
##########
system/nxplayer/nxplayer.c:
##########
@@ -752,21 +752,21 @@ static int nxplayer_enqueuebuffer(FAR struct nxplayer_s
*pplayer,
static void *nxplayer_playthread(pthread_addr_t pvarg)
{
- struct nxplayer_s *pplayer = (struct nxplayer_s *)pvarg;
- struct audio_msg_s msg;
- struct audio_buf_desc_s buf_desc;
- ssize_t size;
- bool running = true;
- bool streaming = true;
- bool failed = false;
- struct ap_buffer_info_s buf_info;
- FAR struct ap_buffer_s **buffers;
- unsigned int prio;
+ struct nxplayer_s *pplayer = (struct nxplayer_s *)pvarg;
Review Comment:
```suggestion
FAR struct nxplayer_s *pplayer = (FAR struct nxplayer_s *)pvarg;
```
##########
system/termcurses/tcurses_vt100.c:
##########
@@ -1126,8 +1126,8 @@ static int tcurses_vt100_getkeycode(FAR struct
termcurses_s *dev,
FAR int *specialkey,
FAR int *keymodifiers)
{
- FAR struct tcurses_vt100_s *priv;
- const struct keycodes_s *pkeycodes;
+ FAR struct tcurses_vt100_s *priv;
+ const struct keycodes_s *pkeycodes;
Review Comment:
```suggestion
FAR const struct keycodes_s *pkeycodes;
```
##########
system/nxrecorder/nxrecorder.c:
##########
@@ -225,21 +225,21 @@ static int nxrecorder_enqueuebuffer(FAR struct
nxrecorder_s *precorder,
static void *nxrecorder_recordthread(pthread_addr_t pvarg)
Review Comment:
```suggestion
static FAR void *nxrecorder_recordthread(pthread_addr_t pvarg)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
