pkarashchenko commented on code in PR #1340:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r991668033
##########
examples/pipe/transfer_test.c:
##########
@@ -70,46 +70,57 @@ static void *transfer_reader(pthread_addr_t pvarg)
int ndx;
printf("transfer_reader: started\n");
- for (nbytes = 0, value = 0; nbytes < NREAD_BYTES;)
+ for (nbytes = 0, value = 0; nbytes < NREAD_BYTES; )
{
ret = read(fd, buffer, READ_SIZE);
- if (ret < 0 )
+ if (ret < 0)
{
- fprintf(stderr, "transfer_reader: read failed, errno=%d\n", errno);
- return (void*)1;
+ fprintf(stderr,
+ "transfer_reader: read failed, errno=%d\n", errno);
+ return (void *)1;
}
else if (ret == 0)
{
if (nbytes < NREAD_BYTES)
{
- fprintf(stderr, "transfer_reader: Too few bytes read --
aborting: %d\n", nbytes);
- return (void*)2;
+ fprintf(stderr,
+ "transfer_reader: Too few bytes read -- aborting: %d\n",
+ nbytes);
+ return (void *)2;
}
break;
}
+
for (ndx = 0; ndx < ret; ndx++)
{
if (value >= WRITE_SIZE)
{
value = 0;
}
+
if (buffer[ndx] != value)
{
- fprintf(stderr, "transfer_reader: Byte %d, expected %d, found
%d\n",
+ fprintf(stderr,
+ "transfer_reader: Byte %d, expected %d, found %d\n",
nbytes + ndx, value, buffer[ndx]);
- return (void*)3;
+ return (void *)3;
}
+
value++;
}
+
nbytes += ret;
if (nbytes > NREAD_BYTES)
{
- fprintf(stderr, "transfer_reader: Too many bytes read -- aborting:
%d\n", nbytes);
- return (void*)4;
+ fprintf(stderr,
+ "transfer_reader: Too many bytes read -- aborting: %d\n",
+ nbytes);
+ return (void *)4;
}
}
+
printf("transfer_reader: %d bytes read\n", nbytes);
- return (void*)0;
+ return (void *)0;
Review Comment:
```suggestion
return NULL;
```
##########
examples/pipe/transfer_test.c:
##########
@@ -70,46 +70,57 @@ static void *transfer_reader(pthread_addr_t pvarg)
int ndx;
printf("transfer_reader: started\n");
- for (nbytes = 0, value = 0; nbytes < NREAD_BYTES;)
+ for (nbytes = 0, value = 0; nbytes < NREAD_BYTES; )
{
ret = read(fd, buffer, READ_SIZE);
- if (ret < 0 )
+ if (ret < 0)
{
- fprintf(stderr, "transfer_reader: read failed, errno=%d\n", errno);
- return (void*)1;
+ fprintf(stderr,
+ "transfer_reader: read failed, errno=%d\n", errno);
+ return (void *)1;
Review Comment:
Do we need FAR here?
##########
examples/pipe/interlock_test.c:
##########
@@ -69,9 +69,10 @@ static void *null_writer(pthread_addr_t pvarg)
fd = open(FIFO_PATH2, O_WRONLY);
if (fd < 0)
{
- fprintf(stderr, "null_writer: Failed to open FIFO %s for writing,
errno=%d\n",
+ fprintf(stderr, "null_writer: "
+ "Failed to open FIFO %s for writing, errno=%d\n",
FIFO_PATH2, errno);
- return (void*)1;
+ return (void *)1;
Review Comment:
Do we need FAR here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
