masayuki2009 commented on PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#issuecomment-1276961009
>nxmutex_t is initialized directly at the variables(g_i2cxdev) definition, not in cxd56_i2cbus_initialize, and then the code can be protected by mutex_t self, so it's redundancy to use the critical section here. That's why this patch remove the critical section too. @xiaoxiang781216 My point is that such optimization is nothing to do with the original intention. (again, the original intention is just to replace nxsem with nxmutex) and should be in another commit. Otherwise, we confuse the commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
