jerpelea commented on code in PR #7248:
URL: https://github.com/apache/incubator-nuttx/pull/7248#discussion_r994217006


##########
drivers/modem/alt1250/alt1250.c:
##########
@@ -0,0 +1,1279 @@
+/****************************************************************************
+ * drivers/modem/alt1250/alt1250.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.  The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <nuttx/kmalloc.h>
+#include <nuttx/fs/fs.h>
+#include <poll.h>
+#include <errno.h>
+#include <nuttx/wireless/lte/lte_ioctl.h>
+#include <nuttx/modem/alt1250.h>
+#include <assert.h>
+
+#include "altcom_pkt.h"
+#include "altcom_hdlr.h"
+#include "altmdm.h"
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+#define WRITE_OK 0
+#define WRITE_NG 1
+
+#define rel_evtbufinst(inst, dev) unlock_evtbufinst(inst, dev)
+
+/****************************************************************************
+ * Private Function Prototypes
+ ****************************************************************************/
+
+/* Character driver methods. */
+
+static int alt1250_open(FAR struct file *filep);
+static int alt1250_close(FAR struct file *filep);
+static ssize_t alt1250_read(FAR struct file *filep, FAR char *buffer,
+  size_t len);
+static int alt1250_ioctl(FAR struct file *filep, int cmd, unsigned long arg);
+static int alt1250_poll(FAR struct file *filep, struct pollfd *fds,
+  bool setup);
+
+parse_handler_t alt1250_additional_parsehdlr(uint16_t, uint8_t);
+compose_handler_t alt1250_additional_composehdlr(uint32_t,
+    FAR uint8_t *, size_t);
+
+/****************************************************************************
+ * Private Data
+ ****************************************************************************/
+
+/* This the vtable that supports the character driver interface. */
+
+static const struct file_operations g_alt1250fops =
+{
+  alt1250_open,  /* open */
+  alt1250_close, /* close */
+  alt1250_read,  /* read */
+  0,             /* write */
+  0,             /* seek */
+  alt1250_ioctl, /* ioctl */
+  alt1250_poll,  /* poll */

Review Comment:
   lets keep it as it is for now 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to