fjpanag commented on code in PR #7286: URL: https://github.com/apache/incubator-nuttx/pull/7286#discussion_r994331743
########## net/tcp/tcp_recvfrom.c: ########## @@ -412,7 +412,8 @@ static uint16_t tcp_recvhandler(FAR struct net_driver_s *dev, * next receive is performed. */ - if (pstate->ir_recvlen > 0) + if ((pstate->ir_recvlen > 0 && (flags & TCP_WAITALL) == 0) || + pstate->ir_buflen == 0) Review Comment: No, as I see `tcp_update_recvlen()` will increase `ir_recvlen` towards the requested amount of data. But this function does not know how much data are requested. On the contrary, the same function will decrease `ir_buflen` towards zero. With zero meaning that all needed data are here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org