xiaoxiang781216 commented on PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#issuecomment-1279049612
> > @pkarashchenko @masayuki2009 @jerpelea all comment get addressed, please
review again.
>
> @xiaoxiang781216
>
> I think it would be better to merge the following style change in the
second commit into the first commit because the first commit also changes the
lines.
>
> ```
> diff --git a/arch/arm/src/cxd56xx/cxd56_udmac.c
b/arch/arm/src/cxd56xx/cxd56_udmac.c
> index 69d2c87aa0..6a490e9cd0 100644
> --- a/arch/arm/src/cxd56xx/cxd56_udmac.c
> +++ b/arch/arm/src/cxd56xx/cxd56_udmac.c
> @@ -68,8 +68,8 @@ struct dma_channel_s
>
> struct dma_controller_s
> {
> - mutex_t lock; /* Protects channel table */
> - sem_t chansem; /* Count of free channels */
> + mutex_t lock; /* Protects channel table */
> + sem_t chansem; /* Count of free channels */
> };
> ```
>
> Also, I can see similar changes in the second commit.
>
> ```
> diff --git a/arch/arm/src/rp2040/rp2040_dmac.c
b/arch/arm/src/rp2040/rp2040_dmac.c
> index 1604c9d829..7d54c70124 100644
> --- a/arch/arm/src/rp2040/rp2040_dmac.c
> +++ b/arch/arm/src/rp2040/rp2040_dmac.c
> @@ -62,8 +62,8 @@ struct dma_channel_s
>
> struct dma_controller_s
> {
> - mutex_t lock; /* Protects channel table */
> - sem_t chansem; /* Count of free channels */
> + mutex_t lock; /* Protects channel table */
> + sem_t chansem; /* Count of free channels */
> };
> ```
Done, move to the first patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
