xiaoxiang781216 commented on code in PR #1350:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1350#discussion_r996431512
##########
nshlib/nsh_init.c:
##########
@@ -66,25 +100,86 @@ static const struct extmatch_vtable_s g_nsh_extmatch =
void nsh_initialize(void)
{
+#if defined (CONFIG_SYSTEM_NSH_SYMTAB)
+ struct boardioc_symtab_s symdesc;
+#endif
+#if defined(CONFIG_NSH_ROMFSETC) && !defined(CONFIG_NSH_DISABLESCRIPT)
+ FAR struct console_stdio_s *pstate;
+#endif
+
#if defined(CONFIG_NSH_READLINE) && defined(CONFIG_READLINE_TABCOMPLETION)
/* Configure the NSH prompt */
readline_prompt(g_nshprompt);
-#ifdef CONFIG_READLINE_HAVE_EXTMATCH
+# ifdef CONFIG_READLINE_HAVE_EXTMATCH
/* Set up for tab completion on NSH commands */
readline_extmatch(&g_nsh_extmatch);
-#endif
+# endif
#endif
/* Mount the /etc filesystem */
(void)nsh_romfsetc();
+#ifdef CONFIG_NSH_USBDEV_TRACE
+ /* Initialize any USB tracing options that were requested */
+
+ usbtrace_enable(TRACE_BITSET);
+#endif
+
+#if defined(CONFIG_SYSTEM_NSH_SYMTAB)
+ /* Make sure that we are using our symbol table */
+
+ symdesc.symtab = (FAR struct symtab_s
*)CONFIG_SYSTEM_NSH_SYMTAB_ARRAYNAME; /* Discard 'const' */
Review Comment:
There are many cases which append the short comment at the end, so it's
better to keep as it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
