yamt opened a new pull request, #7339:
URL: https://github.com/apache/incubator-nuttx/pull/7339

   ## Summary
   
   After the retirement of CONFIG_SCHED_EXIT_KILL_CHILDREN, [1] the behavior is 
now effectively controlled by
   CONFIG_SCHED_CHILD_STATUS, which is IMO confusing. (It was even surprising 
me.)
   
   This commit solves it by making HAVE_GROUP_MEMBERS a synonym of 
!CONFIG_DISABLE_PTHREAD. I guess this change aligns the intention of the 
CONFIG_SCHED_EXIT_KILL_CHILDREN retirement. That is, always tries to be similar 
to the standard behavior.
   
   Another option would be to revive CONFIG_SCHED_EXIT_KILL_CHILDREN and make 
the HAVE_GROUP_MEMBERS logic aware of it. It might be a good idea if we want a 
finer-grained control of code to build. (One can argue his application uses 
pthread but does never _exit. In that case, it might be a waste to maintain 
group membership. I suspect it might not be too rare in embedded world.)
   
   [1] commit 6982eb35feb2daba8a55d7f89c716c28aaf126e0
   
   ## Impact
   
   - _exit behavior
   - code/data size a bit
   
   ## Testing
   
   tested with my app on sim on ubuntu
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to