xiaoxiang781216 commented on code in PR #1362:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1362#discussion_r999034800
##########
system/telnet/telnet_client.c:
##########
@@ -286,7 +297,9 @@ int main(int argc, FAR char *argv[])
#ifdef CONFIG_NET_IPv4
struct sockaddr_in ipv4;
#endif
- } server;
+ }
+
+ server;
Review Comment:
here is the nxstyle warning:
```
apps/system/telnet/telnet_client.c:300:3: error: Right brace must be
followed by a blank line
apps/system/telnet/telnet_client.c:310:3: error: Right brace must be
followed by a blank line
```
##########
system/telnet/telnet_client.c:
##########
@@ -115,13 +115,17 @@ static const struct telnet_telopt_s g_telopts[] =
static void send_local_input(char *buffer, int size)
Review Comment:
the whole code base of telnet doesn't add FAR before pointer, so let's keep
as before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
