pkarashchenko commented on code in PR #1389: URL: https://github.com/apache/incubator-nuttx-apps/pull/1389#discussion_r1008669539
########## examples/ltr308/ltr308_main.c: ########## @@ -0,0 +1,72 @@ +/**************************************************************************** + * apps/examples/ltr308/ltr308_main.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <nuttx/sensors/ioctl.h> +#include <nuttx/sensors/ltr308.h> + +#include <stdio.h> +#include <fcntl.h> +#include <sys/ioctl.h> + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +/**************************************************************************** + * ltr308_main + ****************************************************************************/ + +int main(int argc, FAR char *argv[]) +{ + struct ltr308_ctrl_s ctrl; + uint32_t data = 0; + int fd, ret; + + fd = open("/dev/light0", O_RDONLY); + if (fd < 0) + { + perror("Could not open file"); + return fd; + } + + ctrl.reset = 0; + ctrl.enable = 1; + ret = ioctl(fd, SNIOC_SET_CTRL, &ctrl); + if (ret < 0) + { + perror("Failed to enable the sensors"); + return ret; Review Comment: Close fd ########## examples/ltr308/ltr308_main.c: ########## @@ -0,0 +1,72 @@ +/**************************************************************************** + * apps/examples/ltr308/ltr308_main.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <nuttx/sensors/ioctl.h> +#include <nuttx/sensors/ltr308.h> + +#include <stdio.h> +#include <fcntl.h> +#include <sys/ioctl.h> + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +/**************************************************************************** + * ltr308_main + ****************************************************************************/ + +int main(int argc, FAR char *argv[]) +{ + struct ltr308_ctrl_s ctrl; + uint32_t data = 0; + int fd, ret; + + fd = open("/dev/light0", O_RDONLY); + if (fd < 0) + { + perror("Could not open file"); + return fd; + } + + ctrl.reset = 0; + ctrl.enable = 1; + ret = ioctl(fd, SNIOC_SET_CTRL, &ctrl); + if (ret < 0) + { + perror("Failed to enable the sensors"); + return ret; + } + + ret = ioctl(fd, SNIOC_GET_DATA, &data); + if (ret < 0) + { + perror("Failed to get data"); + return ret; + } + + printf("Data: %x\n", data); Review Comment: Close fd ########## examples/ltr308/ltr308_main.c: ########## @@ -0,0 +1,72 @@ +/**************************************************************************** + * apps/examples/ltr308/ltr308_main.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <nuttx/sensors/ioctl.h> +#include <nuttx/sensors/ltr308.h> + +#include <stdio.h> +#include <fcntl.h> +#include <sys/ioctl.h> + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +/**************************************************************************** + * ltr308_main + ****************************************************************************/ + +int main(int argc, FAR char *argv[]) +{ + struct ltr308_ctrl_s ctrl; + uint32_t data = 0; + int fd, ret; + + fd = open("/dev/light0", O_RDONLY); + if (fd < 0) + { + perror("Could not open file"); + return fd; + } + + ctrl.reset = 0; + ctrl.enable = 1; + ret = ioctl(fd, SNIOC_SET_CTRL, &ctrl); + if (ret < 0) + { + perror("Failed to enable the sensors"); + return ret; + } + + ret = ioctl(fd, SNIOC_GET_DATA, &data); + if (ret < 0) + { + perror("Failed to get data"); + return ret; Review Comment: Close fd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
