pkarashchenko commented on code in PR #7467:
URL: https://github.com/apache/incubator-nuttx/pull/7467#discussion_r1008749585
##########
drivers/video/video.c:
##########
@@ -1455,7 +1455,8 @@ static int validate_frame_setting(enum v4l2_buf_type type,
convert_to_imgsensorfmt(&vfmt[VIDEO_FMT_SUB], &sf[IMGSENSOR_FMT_SUB]);
convert_to_imgsensorinterval(interval, &si);
- ret = g_video_sensor_ops->validate_frame_setting(type, nr_fmt, sf, &si);
+ ret = g_video_sensor_ops->validate_frame_setting(
+ type == V4L2_BUF_TYPE_STILL_CAPTURE, nr_fmt, sf, &si);
Review Comment:
Let's better use
```
((type == V4L2_BUF_TYPE_VIDEO_CAPTURE) ?
IMGSENSOR_STREAM_TYPE_VIDEO : IMGSENSOR_STREAM_TYPE_STILL
```
same as in `start_capture`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
