xiaoxiang781216 commented on code in PR #7472: URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1011105975
########## arch/arm/src/cxd56xx/cxd56_spi.c: ########## @@ -77,7 +77,6 @@ struct cxd56_spidev_s uint8_t port; /* Port number */ int initialized; /* Initialized flag */ #ifdef CONFIG_CXD56_DMAC - bool dmaenable; /* Use DMA or not */ DMA_HANDLE rxdmach; /* RX DMA channel handle */ Review Comment: Yes, because txdmach and rxdmach doesn't initialize at runtime anymore, so dmaenable which is used to identify the initialization result doesn't need too. ########## arch/arm/src/cxd56xx/cxd56_spi.c: ########## @@ -77,7 +77,6 @@ struct cxd56_spidev_s uint8_t port; /* Port number */ int initialized; /* Initialized flag */ #ifdef CONFIG_CXD56_DMAC - bool dmaenable; /* Use DMA or not */ DMA_HANDLE rxdmach; /* RX DMA channel handle */ Review Comment: No, because txdmach and rxdmach doesn't initialize at runtime anymore, so dmaenable which is used to identify the initialization result doesn't need too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
