[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

[GitBox]

xiaoxiang781216 commented on code in PR #7472:
URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1011127817


##########
arch/arm/src/s32k3xx/s32k3xx_edma.c:
##########
@@ -459,7 +445,7 @@ static struct s32k3xx_edmatcd_s *s32k3xx_tcd_alloc(void)
    */
 
   flags = enter_critical_section();
-  s32k3xx_takedsem();
+  nxsem_wait_uninterruptible(&g_edma.dsem);

Review Comment:
   move to new patch



##########
arch/arm/src/s32k3xx/s32k3xx_edma.c:
##########
@@ -416,26 +422,6 @@ const struct peripheral_clock_config_s edma_clockconfig[] =
  * Private Functions
  ****************************************************************************/
 
-/****************************************************************************
- * Name: s32k3xx_takedsem() and s32k3xx_givedsem()
- *
- * Description:
- *   Used to wait for availability of descriptors in the descriptor table.
- *
- ****************************************************************************/
-
-#if CONFIG_S32K3XX_EDMA_NTCD > 0
-static void s32k3xx_takedsem(void)
-{
-  nxsem_wait_uninterruptible(&g_edma.dsem);
-}
-
-static inline void s32k3xx_givedsem(void)
-{
-  nxsem_post(&g_edma.dsem);
-}
-#endif
-

Review Comment:
   move to new patch



##########
arch/arm/src/s32k3xx/s32k3xx_edma.c:
##########
@@ -491,7 +477,7 @@ static void s32k3xx_tcd_free(struct s32k3xx_edmatcd_s *tcd)
 
   flags = spin_lock_irqsave(NULL);
   sq_addlast((sq_entry_t *)tcd, &g_tcd_free);
-  s32k3xx_givedsem();
+  nxsem_post(&g_edma.dsem);

Review Comment:
   move to new patch



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org