xiaoxiang781216 commented on code in PR #7472:
URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1011965214
##########
arch/arm/src/samd2l2/sam_i2c_master.c:
##########
@@ -1253,83 +1307,59 @@ struct i2c_master_s *sam_i2c_master_initialize(int bus)
#ifdef SAMD2L2_HAVE_I2C0
if (bus == 0)
{
- /* Select up I2C0 and setup invariant attributes */
+ /* Select up I2C0 and the (initial) I2C frequency */
priv = &g_i2c0;
- priv->attr = &g_i2c0attr;
-
- /* Select the (initial) I2C frequency */
-
frequency = CONFIG_SAM_I2C0_FREQUENCY;
}
else
#endif
#ifdef SAMD2L2_HAVE_I2C1
if (bus == 1)
{
- /* Select up I2C1 and setup invariant attributes */
+ /* Select up I2C1 and the (initial) I2C frequency */
priv = &g_i2c1;
- priv->attr = &g_i2c1attr;
-
- /* Select the (initial) I2C frequency */
-
frequency = CONFIG_SAM_I2C1_FREQUENCY;
}
else
#endif
#ifdef SAMD2L2_HAVE_I2C2
if (bus == 2)
{
- /* Select up I2C2 and setup invariant attributes */
+ /* Select up I2C2 and the (initial) I2C frequency */
priv = &g_i2c2;
- priv->attr = &g_i2c2attr;
-
- /* Select the (initial) I2C frequency */
-
frequency = CONFIG_SAM_I2C2_FREQUENCY;
}
else
#endif
#ifdef SAMD2L2_HAVE_I2C3
if (bus == 3)
{
- /* Select up I2C3 and setup invariant attributes */
+ /* Select up I2C3 and the (initial) I2C frequency */
priv = &g_i2c3;
- priv->attr = &g_i2c3attr;
-
- /* Select the (initial) I2C frequency */
-
frequency = CONFIG_SAM_I2C3_FREQUENCY;
}
else
#endif
#ifdef SAMD2L2_HAVE_I2C4
if (bus == 4)
{
- /* Select up I2C4 and setup invariant attributes */
+ /* Select up I2C4 and the (initial) I2C frequency */
priv = &g_i2c4;
- priv->attr = &g_i2c4attr;
-
- /* Select the (initial) I2C frequency */
-
frequency = CONFIG_SAM_I2C4_FREQUENCY;
}
else
#endif
#ifdef SAMD2L2_HAVE_I2C5
if (bus == 5)
{
- /* Select up I2C5 and setup invariant attributes */
+ /* Select up I2C5 and the (initial) I2C frequency */
priv = &g_i2c5;
- priv->attr = &g_i2c5attr;
Review Comment:
yes
##########
arch/arm/src/samd2l2/sam_i2c_master.c:
##########
@@ -1253,83 +1307,59 @@ struct i2c_master_s *sam_i2c_master_initialize(int bus)
#ifdef SAMD2L2_HAVE_I2C0
if (bus == 0)
{
- /* Select up I2C0 and setup invariant attributes */
+ /* Select up I2C0 and the (initial) I2C frequency */
priv = &g_i2c0;
- priv->attr = &g_i2c0attr;
-
- /* Select the (initial) I2C frequency */
-
frequency = CONFIG_SAM_I2C0_FREQUENCY;
}
else
#endif
#ifdef SAMD2L2_HAVE_I2C1
if (bus == 1)
{
- /* Select up I2C1 and setup invariant attributes */
+ /* Select up I2C1 and the (initial) I2C frequency */
priv = &g_i2c1;
- priv->attr = &g_i2c1attr;
-
- /* Select the (initial) I2C frequency */
-
frequency = CONFIG_SAM_I2C1_FREQUENCY;
}
else
#endif
#ifdef SAMD2L2_HAVE_I2C2
if (bus == 2)
{
- /* Select up I2C2 and setup invariant attributes */
+ /* Select up I2C2 and the (initial) I2C frequency */
priv = &g_i2c2;
- priv->attr = &g_i2c2attr;
-
- /* Select the (initial) I2C frequency */
-
frequency = CONFIG_SAM_I2C2_FREQUENCY;
}
else
#endif
#ifdef SAMD2L2_HAVE_I2C3
if (bus == 3)
{
- /* Select up I2C3 and setup invariant attributes */
+ /* Select up I2C3 and the (initial) I2C frequency */
priv = &g_i2c3;
- priv->attr = &g_i2c3attr;
-
- /* Select the (initial) I2C frequency */
-
frequency = CONFIG_SAM_I2C3_FREQUENCY;
}
else
#endif
#ifdef SAMD2L2_HAVE_I2C4
if (bus == 4)
{
- /* Select up I2C4 and setup invariant attributes */
+ /* Select up I2C4 and the (initial) I2C frequency */
priv = &g_i2c4;
- priv->attr = &g_i2c4attr;
Review Comment:
yes
##########
arch/arm/src/samd2l2/sam_i2c_master.c:
##########
@@ -1253,83 +1307,59 @@ struct i2c_master_s *sam_i2c_master_initialize(int bus)
#ifdef SAMD2L2_HAVE_I2C0
if (bus == 0)
{
- /* Select up I2C0 and setup invariant attributes */
+ /* Select up I2C0 and the (initial) I2C frequency */
priv = &g_i2c0;
- priv->attr = &g_i2c0attr;
-
- /* Select the (initial) I2C frequency */
-
frequency = CONFIG_SAM_I2C0_FREQUENCY;
}
else
#endif
#ifdef SAMD2L2_HAVE_I2C1
if (bus == 1)
{
- /* Select up I2C1 and setup invariant attributes */
+ /* Select up I2C1 and the (initial) I2C frequency */
priv = &g_i2c1;
- priv->attr = &g_i2c1attr;
-
- /* Select the (initial) I2C frequency */
-
frequency = CONFIG_SAM_I2C1_FREQUENCY;
}
else
#endif
#ifdef SAMD2L2_HAVE_I2C2
if (bus == 2)
{
- /* Select up I2C2 and setup invariant attributes */
+ /* Select up I2C2 and the (initial) I2C frequency */
priv = &g_i2c2;
- priv->attr = &g_i2c2attr;
-
- /* Select the (initial) I2C frequency */
-
frequency = CONFIG_SAM_I2C2_FREQUENCY;
}
else
#endif
#ifdef SAMD2L2_HAVE_I2C3
if (bus == 3)
{
- /* Select up I2C3 and setup invariant attributes */
+ /* Select up I2C3 and the (initial) I2C frequency */
priv = &g_i2c3;
- priv->attr = &g_i2c3attr;
Review Comment:
yes
##########
arch/arm/src/samd2l2/sam_i2c_master.c:
##########
@@ -1253,83 +1307,59 @@ struct i2c_master_s *sam_i2c_master_initialize(int bus)
#ifdef SAMD2L2_HAVE_I2C0
if (bus == 0)
{
- /* Select up I2C0 and setup invariant attributes */
+ /* Select up I2C0 and the (initial) I2C frequency */
priv = &g_i2c0;
- priv->attr = &g_i2c0attr;
-
- /* Select the (initial) I2C frequency */
-
frequency = CONFIG_SAM_I2C0_FREQUENCY;
}
else
#endif
#ifdef SAMD2L2_HAVE_I2C1
if (bus == 1)
{
- /* Select up I2C1 and setup invariant attributes */
+ /* Select up I2C1 and the (initial) I2C frequency */
priv = &g_i2c1;
- priv->attr = &g_i2c1attr;
Review Comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
