antmerlino commented on code in PR #7528: URL: https://github.com/apache/incubator-nuttx/pull/7528#discussion_r1014961123
########## net/sixlowpan/sixlowpan_tcpsend.c: ########## @@ -242,33 +242,19 @@ static int sixlowpan_tcp_header(FAR struct tcp_conn_s *conn, memcpy(ipv6tcp->tcp.ackno, conn->rcvseq, 4); /* ACK number */ memcpy(ipv6tcp->tcp.seqno, conn->sndseq, 4); /* Sequence number */ - /* Set the TCP window */ + /* Update the TCP received window based on I/O buffer availability */ - if (conn->tcpstateflags & TCP_STOPPED) Review Comment: I see. I can't seem to find whether it was ever set or not. Alot has changed. I can try and dig into it later, but not sure when I'll have time. If it wasn't ever fully supported, then it likely came from the Contiki port that Greg originally did. In either case - why get rid of this logic? It seems like the right behavior, even if right now we don't look for the STOPPED flag right now. If we were to look for the STOPPED flag, then this would be right. What's the rationale for removing it? The STOPPED flag is a legitimate TCP flag. This logic, likely copied from Contiki, is correct. I think we should either set the STOPPED flag and allow this logic to do it's job, or not remove it and leave it as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
