xiaoxiang781216 commented on code in PR #7595:
URL: https://github.com/apache/incubator-nuttx/pull/7595#discussion_r1024228939
##########
arch/arm/src/sama5/sam_adc.c:
##########
@@ -497,20 +498,11 @@ static const struct adc_ops_s g_adcops =
/* ADC internal state */
-static struct sam_adc_s g_adcpriv =
-{
- .lock = NXMUTEX_INITIALIZER,
-};
+static struct sam_adc_s g_adcpriv;
/* ADC device instance */
-static struct adc_dev_s g_adcdev =
-{
-#ifdef SAMA5_ADC_HAVE_CHANNELS
- .ad_ops = &g_adcops,
-#endif
- .ad_priv = &g_adcpriv,
-};
+static struct adc_dev_s g_adcdev;
Review Comment:
why change
##########
arch/arm/src/sama5/sam_adc.c:
##########
@@ -497,20 +498,11 @@ static const struct adc_ops_s g_adcops =
/* ADC internal state */
-static struct sam_adc_s g_adcpriv =
-{
- .lock = NXMUTEX_INITIALIZER,
-};
+static struct sam_adc_s g_adcpriv;
Review Comment:
why change
##########
arch/arm/src/sama5/Kconfig:
##########
@@ -3615,6 +3615,16 @@ config SAMA5_ADC_SWTRIG
---help---
A-to-D Conversion is initiated only by software via an ioctl()
+config SAMA5_ADC_PERIODIC_TRIG
+ bool "Periodic trigger"
+ ---help---
+ A-to-D Conversion is triggered periodically
+
+config SAMA5_ADC_CONTINUOUS_TRIG
Review Comment:
does SAMA5_ADC_PERIODIC_TRIG and SAMA5_ADC_CONTINUOUS_TRIG work at the same
time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
