masayuki2009 commented on code in PR #7627: URL: https://github.com/apache/incubator-nuttx/pull/7627#discussion_r1029025457
########## boards/arm/cxd56xx/spresense/configs/wifi_smp/defconfig: ########## @@ -105,12 +105,9 @@ CONFIG_NETUTILS_HTTPD_SENDFILE=y CONFIG_NETUTILS_TELNETD=y CONFIG_NETUTILS_WEBCLIENT=y CONFIG_NETUTILS_WEBSERVER=y -CONFIG_NET_BROADCAST=y -CONFIG_NET_ICMP_NO_STACK=y -CONFIG_NET_TCP_NO_STACK=y -CONFIG_NET_UDP_NO_STACK=y CONFIG_NET_USRSOCK=y CONFIG_NET_USRSOCK_CONNS=16 +CONFIG_NET_USRSOCK_ICMP=y CONFIG_NET_USRSOCK_UDP=y Review Comment: @xiaoxiang781216 Because the GS2200M does not support ICMP, I think it should be removed. ########## boards/arm/cxd56xx/spresense/configs/wifi/defconfig: ########## @@ -102,12 +102,9 @@ CONFIG_NETUTILS_HTTPD_SENDFILE=y CONFIG_NETUTILS_TELNETD=y CONFIG_NETUTILS_WEBCLIENT=y CONFIG_NETUTILS_WEBSERVER=y -CONFIG_NET_BROADCAST=y -CONFIG_NET_ICMP_NO_STACK=y -CONFIG_NET_TCP_NO_STACK=y -CONFIG_NET_UDP_NO_STACK=y CONFIG_NET_USRSOCK=y CONFIG_NET_USRSOCK_CONNS=16 +CONFIG_NET_USRSOCK_ICMP=y CONFIG_NET_USRSOCK_UDP=y Review Comment: @xiaoxiang781216 Because the GS2200M does not support ICMP, I think it should be removed. ########## boards/arm/stm32/stm32f4discovery/configs/wifi/defconfig: ########## @@ -55,12 +55,9 @@ CONFIG_NETUTILS_HTTPD_SENDFILE=y CONFIG_NETUTILS_TELNETD=y CONFIG_NETUTILS_WEBCLIENT=y CONFIG_NETUTILS_WEBSERVER=y -CONFIG_NET_BROADCAST=y -CONFIG_NET_ICMP_NO_STACK=y -CONFIG_NET_TCP_NO_STACK=y -CONFIG_NET_UDP_NO_STACK=y CONFIG_NET_USRSOCK=y CONFIG_NET_USRSOCK_CONNS=16 +CONFIG_NET_USRSOCK_ICMP=y CONFIG_NET_USRSOCK_UDP=y Review Comment: @xiaoxiang781216 Because the GS2200M does not support ICMP, I think it should be removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
